[CASSANDRA-9986] Remove SliceableUnfilteredRowIterator

• Type: Sub-task
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.4
• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Sylvain Lebresne

• Created: 05/Aug/15 08:23
• Updated: 16/Apr/19 09:31
• Resolved: 25/Jan/16 10:53

Description

After CASSANDRA-9932, there is only one instance where this class is needed, and that is SSTableIterator. It would be much simpler if, like in AbstractBTreePartition, the slices were passed into the SSTableIterator on construction. This would make the control flow easier to follow both:

• logically, because:
  • memtables and sstables would have the same access pattern; and
  • our SSTableIterator would not have two modes of (parallel) operation, which is kind of confusing (the slices are independent of the non-sliced iteration)
• in the debugger, because we would have one fewer wrapping iterator