[CASSANDRA-9919] Cleanup closeable iterator usage

• Type: Improvement
• Status: Open
• Priority: Normal
• Resolution: Unresolved
• Fix Version/s: 5.x
• Component/s: Legacy/Core
• Epic Link: Code Style & Static Analysis
• Assignee: Unassigned
• Reporter: Benedict Elliott Smith
• Created: 29/Jul/15 15:07
• Updated: 13/Nov/23 09:48

Description

Our iterators are all sensibly AutoCloseable, but we still have a lot of places where we close the iterator if we reach the end in next() / hasNext(). ThIs behaviour will only mask problems, as any exceptions in normal processing will miss these pathways. Since we much more heavily depend on iterators now, we need to be certain they are rock solid. So I would prefer we remove our crutches and work through any pain earlier.

CASSANDRA-9918 can then help us catch any misuse more easily.