Details

    • Sub-task
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 3.0 alpha 1
    • None
    • None

    Description

      There is some small improvements/refactor I'd like to do for RowStats. More specifically, I'm attaching 3 commits:

      1. the first one merely rename RowStats to EncodingStats. RowStats was not a terribly helpful name while EncodingStats at least give a sense of why the thing exists.
      2. the 2nd one improve the serialization of those EncodingStats. EncodingStats holds both a minTimestamp and a minLocalDeletionTime, both of which are unix timestamp (or at least should be almost all the time for the timestamp by convention) and so are fairly big numbers that don't get much love (if any) from vint encoding. So the patch introducing hard-coded epoch numbers for both that roughly correspond to now, and substract that to the actual EncodingStats number to make it more rip for vint encoding. It does mean the exact encoding size will deteriorate over time, but it'll take a while before it becomes useless and we'll probably have more more change to the encodings by then anyway (and/or we can change the epoch number regularly with new versions of the messaging protocol if we so wish).
      3. the last patch is just a small simple cleanup.

      Attachments

        Activity

          People

            slebresne Sylvain Lebresne
            slebresne Sylvain Lebresne
            Sylvain Lebresne
            Joshua McKenzie
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: