[CASSANDRA-9700] StreamSession selects canonical sstables, but uses the non-canonical instance

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.1.8
• Severity: Normal
• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Yuki Morishita

• Created: 01/Jul/15 17:19
• Updated: 16/Apr/19 09:31
• Resolved: 02/Jul/15 18:13

Description

While implementing CASSANDRA-9699, I noticed that we are only checking that there is a canonical reader in StreamSession.getSSTablesForRanges, not that we are using the canonical instance. This means we are not using the full range of the sstable.

I'm not absolutely sure if this is a problem of correctness, as I'm not sufficiently versed in how incremental repair works, but it looks worrisome to me.

Issue Links

• relates to: CASSANDRA-11886 Streaming will miss sections for early opened sstables during compaction