[CASSANDRA-9537] Sstables created with MockSchema occasionally triggers assertions

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.0 rc1
• Component/s: Legacy/Testing
• Labels: test-failure
• Assignee: Stefania Alborghetti
• Reporter: Stefania Alborghetti

Authors

Stefania Alborghetti

Reviewers

Benedict Elliott Smith

• Created: 03/Jun/15 06:32
• Updated: 16/Apr/19 09:31
• Resolved: 03/Jun/15 13:16

Description

It's extremely hard to reproduce but occasionally some Jenkins tests fail as follows:

http://cassci.datastax.com/job/trunk_utest/229/testReport/org.apache.cassandra.db.lifecycle/TrackerTest/testAddInitialSSTables/

junit.framework.AssertionFailedError
	at org.apache.cassandra.utils.concurrent.Ref$State.assertNotReleased(Ref.java:157)
	at org.apache.cassandra.utils.concurrent.Ref.ref(Ref.java:113)
	at org.apache.cassandra.io.sstable.format.SSTableReader$GlobalTidy.get(SSTableReader.java:2111)
	at org.apache.cassandra.io.sstable.format.SSTableReader$DescriptorTypeTidy.<init>(SSTableReader.java:1980)
	at org.apache.cassandra.io.sstable.format.SSTableReader$DescriptorTypeTidy.get(SSTableReader.java:2017)
	at org.apache.cassandra.io.sstable.format.SSTableReader$InstanceTidier.setup(SSTableReader.java:1897)
	at org.apache.cassandra.io.sstable.format.SSTableReader.setup(SSTableReader.java:1842)
	at org.apache.cassandra.io.sstable.format.SSTableReader.internalOpen(SSTableReader.java:530)
	at org.apache.cassandra.MockSchema.sstable(MockSchema.java:128)
	at org.apache.cassandra.MockSchema.sstable(MockSchema.java:92)
	at org.apache.cassandra.MockSchema.sstable(MockSchema.java:87)
	at org.apache.cassandra.db.lifecycle.TrackerTest.testAddInitialSSTables(TrackerTest.java:146)

I propose not to reuse cfname in MockSchema.sstable() and in fact to get rid of the shared MockSchema.cfs which has caused other test problems, see CASSANDRA-9514.

Issue Links

• relates to: CASSANDRA-9514 TrackerTest.testAddSSTables fails in 2.2 and trunk
• links to: Patch for 2.2