[CASSANDRA-9530] SSTable corruption can trigger OOM

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.7, 3.7, 3.8
• Component/s: Legacy/Local Write-Read Paths
• Severity: Normal
• Assignee: Alex Petrov
• Reporter: Sylvain Lebresne

Authors

Alex Petrov

Reviewers

Stefania Alborghetti

• Created: 02/Jun/15 13:25
• Updated: 24/Apr/23 19:20
• Resolved: 26/May/16 02:59

Description

If a sstable is corrupted so that the length of a given value is bogus, we'll still happily try to allocate a buffer of that bogus size to read the value, which can easily lead to an OOM.

We should probably protect against this. In practice, a given value can be so big since it's limited by the protocol frame size in the first place. Maybe we could add a max_value_size_in_mb setting and we'd considered a sstable corrupted if it was containing a value bigger than that.

I'll note that this ticket would be a good occasion to improve BlacklistingCompactionsTest. Typically, it currently generate empty values which makes it pretty much impossible to get the problem described here. And as described in CASSANDRA-9478, it also doesn't test properly for thing like early opening of compaction results. We could try to randomize as much of the parameters of this test as possible to make it more likely to catch any type of corruption that could happen.

Issue Links

• is related to: CASSANDRA-8048 Add WARN for large resultsets