[CASSANDRA-9508] Avoid early opening of compaction results when doing anticompaction

• Type: Bug
• Status: Resolved
• Priority: Urgent
• Resolution: Fixed
• Fix Version/s: 2.1.6, 2.2.0 rc1, 3.0 alpha 1
• Component/s: Local/Compaction
• Severity: Critical
• Assignee: Marcus Eriksson
• Reporter: Marcus Eriksson

Authors

Marcus Eriksson

Reviewers

Benedict Elliott Smith

• Created: 29/May/15 06:09
• Updated: 16/Apr/19 09:31
• Resolved: 29/May/15 08:00

Description

When doing anticompaction we have 2 sstable rewriters open and write the repaired range to one writer and the unrepaired to one. This can cause some keys to become unreadable during anticompaction, example:

Say we are anticompacting one 150MB sstable into two new ones, 75MB each, first we start writing to the first one, after 50MB, we open the result early and move the start point up to the 50MB mark in the original file. Then, after 75MB written, we start writing to the next file and after writing 50MB to that file, we open that file early and move the start point up to 125MB in the original file. This makes 25MB unreadable that is only present in the first file written, but we have moved the start point beyond that part of the file in the original

Simple solution is probably to avoid doing early opening during anticompaction, and since anticompaction is not as frequent as ordinary compactions, the performance implications would not be too big

Issue Links

• is broken by: CASSANDRA-6916 Preemptive opening of compaction result
• is duplicated by: CASSANDRA-9482 SSTable leak after stress and repair