[CASSANDRA-9438] Repair version gating will do the wrong thing in rc/beta dev builds

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.0 rc1
• Component/s: Legacy/Streaming and Messaging
• Severity: Normal
• Assignee: Yuki Morishita
• Reporter: Jeremiah Jordan

Authors

Yuki Morishita

Reviewers

Jeremiah Jordan

• Created: 20/May/15 14:15
• Updated: 16/Apr/19 09:31
• Resolved: 26/May/15 15:51

Description

The version check gate in AnticompactionTask will fail with -betaX-SNAPSHOT and -rcX-SNAPSHOT builds. As SystemKeyspace.getReleaseVersion will return null for those. This means dtests and anyone else testing with dev builds will be getting the wrong repair behavior.

AnticompactionTask.java

        SemanticVersion peerVersion = SystemKeyspace.getReleaseVersion(neighbor);
        if (peerVersion != null && peerVersion.compareTo(VERSION_CHECKER) > 0)
        {
            MessagingService.instance().sendRR(acr.createMessage(), neighbor, new AnticompactionCallback(this), TimeUnit.DAYS.toMillis(1), true);
        }
        else
        {
            MessagingService.instance().sendOneWay(acr.createMessage(), neighbor);
            // immediately return after sending request
            set(neighbor);
        }

Issue Links

• relates to: CASSANDRA-9422 SystemKeyspaceTest fails with non-release version string