[CASSANDRA-9314] Overload SecondaryIndex#indexes to accept the column definition

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.0.15, 2.1.6, 2.2.0 beta 1
• Assignee: Sergio Bossa
• Reporter: Sergio Bossa

Authors

Sergio Bossa

Reviewers

Sam Tunnicliffe

• Created: 06/May/15 12:02
• Updated: 16/Apr/19 09:31
• Resolved: 07/May/15 10:58

Description

In order to avoid rebuilding indexes when no columns are actually indexed (originally implemented in CASSANDRA-9196), CASSANDRA-9281 hinted at overriding SecondaryIndex#getColumnDefs to "filter out" indexes that shouldn't be rebuilt; unfortunately, I believe this would be quite wrong for safety reasons, as it could have side effects on other methods relying on getColumnDefs returning a stable set, and API consistency ones, as it would be confusing to have getColumnDefs behave differently based on runtime conditions, possibly ignoring addColumnDef calls.

I believe SecondaryIndex#indexes is still the best candidate to act as a filter predicate, and I propose to overload it to accept a column definition for all those cases (i.e. index rebuilding) missing a full cell name.

Issue Links

• is related to: CASSANDRA-9281 Index selection during rebuild fails with certain table layouts.
• is related to: CASSANDRA-9196 Do not rebuild indexes if no columns are actually indexed