[CASSANDRA-9299] Fix counting of tombstones towards TombstoneOverwhelmingException

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.0.15, 2.1.6
• Severity: Normal
• Assignee: Aleksey Yeschenko Assign to me
• Reporter: Aleksey Yeschenko

Authors

Aleksey Yeschenko

Reviewers

Tom Hobbs

• Created: 05/May/15 13:31
• Updated: 16/Apr/19 09:31
• Resolved: 12/May/15 18:36

Description

CASSANDRA-6042 introduced warning on too many tombstones scanned, then CASSANDRA-6117 introduced a hard TombstoneOverwhelmingException condition.

However, at least SliceQuerFilter.collectReducedColumn() seems to have the logic wrong. Cells that are covered by a range tombstone or a partition high level deletion, still count towards ColumnCounter's ignored register.

Thus it's possible to have an otherwise healthy (though large) dropped partition read cause an exception that shouldn't be there.

The only things that should count towards the exception are cell tombstones and range tombstones (CASSANDRA-8527), but never ever live cells shadowed by any kind of tombstone.

Issue Links

• is related to: CASSANDRA-9326 Seeing tombstone warning message
• is related to: CASSANDRA-9815 Tracing doesn't seem to display tombstones read accurately
• is related to: CASSANDRA-9221 No test coverage for TombstoneOverwhelmingException