[CASSANDRA-9265] Add checksum to saved cache files

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.1, 3.0 beta 1
• Assignee: Daniel Chia
• Reporter: Ariel Weisberg

Authors

Daniel Chia

Reviewers

Ariel Weisberg

• Created: 29/Apr/15 17:39
• Updated: 16/Apr/19 09:31
• Resolved: 06/Aug/15 18:56

Description

Saved caches are not covered by a checksum. We should at least emit a checksum. My suggestion is a large checksum of the whole file (convenient offline validation), and then smaller per record checksums after each record is written (possibly a subset of the incrementally maintained larger checksum).

I wouldn't go for anything fancy to try to recover from corruption since it is just a saved cache. If corruption is detected while reading I would just have it bail out. I would rather have less code to review and test in this instance.

Issue Links

• blocks: CASSANDRA-9264 Cassandra should not persist files without checksums
• breaks: CASSANDRA-10155 2i key cache load fails
• supercedes: CASSANDRA-9120 OutOfMemoryError when read auto-saved cache (probably broken)