[CASSANDRA-9219] Follow-ups to 7523: protect old clients from new type values and reject empty ByteBuffer

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.0 beta 1
• Component/s: Legacy/CQL
• Impacts: Clients
• Assignee: Joshua McKenzie
• Reporter: Joshua McKenzie

Authors

Joshua McKenzie

Reviewers

Aleksey Yeschenko

• Created: 21/Apr/15 13:50
• Updated: 06/Nov/19 21:58
• Resolved: 14/May/15 20:36

Description

2 follow-ups from CASSANDRA-7523, which has now been removed from the 2.1 branch:

The problem is that if someone use one of those new data types with an existing client, Cassandra will currently happily return the new codes, which clients have no reason to know about and may therefore crash in unexpected ways. That is a problem and that's what I meant by "Adding new codes to v3 would confuse drivers".

So what I mean is that we should special case those 2 types in DataType (maybe in toType, maybe directly in the serialization) so that when the protocol version is <= 3, then it write the types as CUSTOM ones.

And

can we make the new types non-emptiable by default? See the last two CASSANDRA-8951 comments.

Would really like us to reject empty BB as a valid value there though

Issue Links

• is related to: CASSANDRA-7523 add date and time types