[CASSANDRA-8771] Remove commit log segment recycling

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.0 beta 1
• Component/s: Legacy/Local Write-Read Paths
• Labels: commitlog
• Assignee: Ariel Weisberg
• Reporter: Ariel Weisberg

Authors

Ariel Weisberg

• Created: 10/Feb/15 01:11
• Updated: 16/Apr/19 09:31
• Resolved: 29/Jul/15 15:46

Description

For discussion

Commit log segment recycling introduces a lot of complexity in the existing code.

CASSANDRA-8729 is a side effect of commit log segment recycling and addressing it will require memory management code and thread coordination for memory that the filesystem will no longer handle for us.

There is some discussion about what storage configurations actually benefit from preallocated files. Fast random access devices like SSDs, or non-volatile write caches etc. make the distinction not that great.

I haven't measured any difference in throughput for bulk appending vs overwriting although it was pointed out that I didn't test with concurrent IO streams.

What would it take to make removing commit log segment recycling acceptable? Maybe a benchmark on a spinning disk that measures the performance impact of preallocation when there are other IO streams?

Issue Links

• is blocked by: CASSANDRA-6809 Compressed Commit Log
• is related to: CASSANDRA-9896 Add ability to disable commitlog recycling
• relates to: CASSANDRA-8729 Commitlog causes read before write when overwriting