[CASSANDRA-8584] Add rate limited logging of failed trySkipCache calls and commit log lag

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.0 alpha 1
• Component/s: Legacy/Local Write-Read Paths, Legacy/Observability
• Assignee: Ariel Weisberg
• Reporter: Joshua McKenzie

Authors

Ariel Weisberg

Reviewers

Benedict Elliott Smith

• Created: 08/Jan/15 18:09
• Updated: 16/Apr/19 09:31
• Resolved: 24/Jun/15 11:09

Description

Since trySkipCache returns an errno rather than -1 and setting errno like our other CLibrary calls, it's thread-safe and we could print out more helpful information if we failed to prompt the kernel to skip the page cache. That system call should always succeed unless we have an invalid fd as it's free to ignore us.

Commit log lag is already rate limited by its own implementation. Convert to use NoSpamLogger.

Issue Links

• relates to: CASSANDRA-9029 Add utility class to support for rate limiting a given log statement