Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-8513

SSTableScanner may not acquire reference, but will still release it when closed

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Duplicate
    • Fix Version/s: 2.1.3
    • Component/s: None
    • Labels:
      None
    • Severity:
      Normal

      Description

      getRangeSlice and related methods do not require a reference to perform a safe read, so during one it is possible for SSTableScanner to fail to acquire a reference to the table it's being created on. In this case it doesn't fail, but it also doesn't log that no reference was acquired; on close, it still releases the reference that it never held.

      We can fix this one of two ways: we can tell the scanner if we require a reference to be acquired; or we can track if one was obtained. The former is a bit more invasive but probably better, since we probably care if we fail to grab one in cases where we need it, and probably don't want to grab one otherwise.

        Attachments

        1. 8513.txt
          2 kB
          Benedict Elliott Smith

          Issue Links

            Activity

              People

              • Assignee:
                benedict Benedict Elliott Smith
                Reporter:
                benedict Benedict Elliott Smith
                Authors:
                Benedict Elliott Smith
                Reviewers:
                Marcus Eriksson
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: