[CASSANDRA-8208] Inconsistent failure handling with repair

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.0 beta 1
• Component/s: Legacy/Streaming and Messaging
• Labels: repair
• Severity: Normal
• Assignee: Yuki Morishita Assign to me
• Reporter: Marcus Eriksson

Authors

Yuki Morishita

Reviewers

Marcus Eriksson

• Created: 29/Oct/14 14:17
• Updated: 16/Apr/19 09:31
• Resolved: 13/Nov/14 18:57

Description

I think we introduced this with CASSANDRA-6455, problem is that we now treat all repair futures as a single unit (Futures.allAsList(..)) which makes the whole thing fail if one sub-future fails. Also, when one of those fail, we notify nodetool that we failed and we stop the executor with shutdownNow() which throws out any pending RepairJobs.

Yuki Morishita I think we used to be able to proceed with the other RepairSessions even if one fails, right? If not, we should probably call cancel on the RepairJob runnables which are in queue for the executor after calling shutdownNow() in repairComplete() in StorageService.

Issue Links

• blocks: CASSANDRA-5839 Save repair data to system table