[CASSANDRA-7981] Refactor SelectStatement

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.0 beta 1
• Component/s: Legacy/CQL
• Severity: Normal
• Assignee: Benjamin Lerer Assign to me
• Reporter: Benjamin Lerer

Authors

Benjamin Lerer

Reviewers

Tom Hobbs

• Created: 19/Sep/14 09:05
• Updated: 16/Apr/19 09:31
• Resolved: 02/Dec/14 19:12

Description

The current state of the code of SelectStatement make fixing some issues or adding new functionnalities really hard. It also contains some functionnalities that we would like to reuse in ModificationStatement but cannot for the moment.

Ideally I would like to:

• Perform as much validation as possible on Relations instead of performing it on Restrictions as it will help for problem like the one of #CASSANDRA-6075 (I believe that by clearly separating validation and Restrictions building we will also make the code a lot clearer)
• Provide a way to easily merge restrictions on the same columns as needed for #CASSANDRA-7016
• Have a preparation logic (validation + pre-processing) that we can easily reuse for Delete statement #CASSANDRA-6237
• Make the code much easier to read and safer to modify.

Issue Links

• breaks: CASSANDRA-8418 Queries that require allow filtering are working without it
• is required by: CASSANDRA-7016 Allow mixing token and partition key restrictions
• is required by: CASSANDRA-6237 Allow range deletions in CQL