[CASSANDRA-7736] Clean-up, justify (and reduce) each use of @Inline

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.1.1
• Component/s: Local/Config
• Assignee: T Jake Luciani
• Reporter: Benedict Elliott Smith

Authors

T Jake Luciani

Reviewers

Benedict Elliott Smith

• Created: 10/Aug/14 21:48
• Updated: 16/Apr/19 09:31
• Resolved: 09/Sep/14 22:41

Description

@Inline is a delicate tool, and should in all cases we've used it (and use it in future) be accompanied by a comment justifying its use in the given context both theoretically and, preferably, with some brief description of/link to steps taken to demonstrate its benefit. We should aim to not use it unless we are very confident we can do better than the normal behaviour, as poor use can result in a polluted instruction cache, which can yield better results in tight benchmarks, but worse results in general use.

It looks to me that we have too many uses already. I'll look over each one as well, and we can compare notes. If there's disagreement on any use, we can discuss, and if still there is any dissent should always err in favour of not using @Inline.

Issue Links

• relates to: CASSANDRA-6755 Optimise CellName/Composite comparisons for NativeCell