[CASSANDRA-7735] Remove ref-counting of netty buffers

• Type: Bug
• Status: Resolved
• Priority: Urgent
• Resolution: Fixed
• Fix Version/s: 2.1 rc6
• Labels: correctness performance
• Severity: Critical
• Since Version: 2.1 beta1
• Assignee: T Jake Luciani
• Reporter: Benedict Elliott Smith

Authors

T Jake Luciani

Reviewers

Benedict Elliott Smith

• Created: 10/Aug/14 20:38
• Updated: 16/Apr/19 09:31
• Resolved: 12/Aug/14 00:41

Description

This has turned out to be more bug prone than we'd hoped, and it no longer seems to be a justified risk factor, since the performance gains were generally quite modest. When there's some time we can reengineer the API to make it safer to produce more obviously correct usage, but in the meantime I propose rolling back this change before general availability of 2.1

Issue Links

• duplicates: CASSANDRA-6861 Optimise our Netty 4 integration
• supercedes: CASSANDRA-7732 Counter replication mutation can have corrupt cell name values (via pooled Netty buffers)