[CASSANDRA-7669] nodetool fails to connect when ipv6 host is specified

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 1.2.19, 2.0.10, 2.1.0
• Component/s: Tool/nodetool

Environment

java version "1.7.0_65"
Java(TM) SE Runtime Environment (build 1.7.0_65-b17)
Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode)

• Severity: Low
• Assignee: Adam Holmberg
• Reporter: Adam Holmberg

Authors

Adam Holmberg

Reviewers

Robert Stupp

• Created: 01/Aug/14 22:07
• Updated: 16/Apr/19 09:31
• Resolved: 04/Aug/14 17:09

Description

The NodeProbe fmtUrl does not account for ipv6 addresses specified for 'host'.

nodetool -h with ipv6 host address fails with cryptic error message

Adding square brackets as in http://www.ietf.org/rfc/rfc3986.txt section 3.2.2 corrects this behavior. Patch attached.

Before

aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; eval $cmd; done
bin/nodetool -h localhost -p 7100 version
ReleaseVersion: 2.1.0-rc4-SNAPSHOT
bin/nodetool -h 127.0.0.1 -p 7100 version
ReleaseVersion: 2.1.0-rc4-SNAPSHOT
bin/nodetool -h ::1 -p 7100 version
nodetool: For input string: ":1:7100"
See 'nodetool help' or 'nodetool help <command>'.
bin/nodetool -h 0::1 -p 7100 version
nodetool: For input string: ":1:7100"
See 'nodetool help' or 'nodetool help <command>’.

After

aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; eval $cmd; done
bin/nodetool -h localhost -p 7100 version
ReleaseVersion: 2.1.0-rc4-SNAPSHOT
bin/nodetool -h 127.0.0.1 -p 7100 version
ReleaseVersion: 2.1.0-rc4-SNAPSHOT
bin/nodetool -h ::1 -p 7100 version
ReleaseVersion: 2.1.0-rc4-SNAPSHOT
bin/nodetool -h 0::1 -p 7100 version
ReleaseVersion: 2.1.0-rc4-SNAPSHOT