Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-7597

Remove static initializer in DatabaseDescriptor

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Normal
    • Resolution: Unresolved
    • Fix Version/s: None
    • Labels:
    • Environment:

      Cassandra 2.0.9 (earlier version should be affected as well)

      Description

      As discussed below, it's difficult to properly react on invalid configuration values in a client tool that uses cassandra code (here: an sstable loader).

      Reason is that the static initializer in DatabaseDescriptor calls System.exit in case of configuration failures.

      Recommend to implement some "loadAndApplyConfig" method on DatabaseDescriptor and remove the static initializer and let the calling code react accordingly (print error, exit VM).

      All direct and indirect uses of DatabaseDescriptor must be catched to solve this ticket - so this is not a 2.1 ticket.

      --------------------------

      Old Description:

      We're using SSTableSimpleUnsortedWriter API to generate SSTable to be loaded into cassandra. In case of any issue with config DatabaseDescriptor calls System.exit() which is apparently not the thing you expect while using API.

      Test case is simple:
      System.setProperty( "cassandra.config", "" );
      new YamlConfigurationLoader().loadConfig();
      Thread.sleep( 5000 );
      System.out.println("We're still alive"); // this will never be called

        Attachments

        1. 7597.txt
          21 kB
          Robert Stupp

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                pavel_sakun Pavel Sakun
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated: