[CASSANDRA-7330] Infinite loop in StreamReader.read during exception condition while running repair

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.0.9
• Component/s: Legacy/Streaming and Messaging
• Labels: Core

Environment

2.0.8+

• Severity: Low
• Assignee: Joshua McKenzie Assign to me
• Reporter: Joshua McKenzie

Authors

Joshua McKenzie

Reviewers

Marcus Eriksson

• Created: 30/May/14 21:02
• Updated: 16/Apr/19 09:31
• Resolved: 03/Jun/14 06:15

Description

InputStream.skip is returning -1 during exception conditions which leads the following logic to infinite loop:

loop

protected void drain(InputStream dis, long bytesRead) throws IOException
{
    long toSkip = totalSize() - bytesRead;
    toSkip = toSkip - dis.skip(toSkip);
    while (toSkip > 0)
        toSkip = toSkip - dis.skip(toSkip);
}