Uploaded image for project: 'Apache Cassandra'
  1. Apache Cassandra
  2. CASSANDRA-7269

Make CqlInputFormat and CqlRecordReader consistent with comments

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 2.1.3
    • None
    • Low

    Description

      Both the CqlInputFormat and CqlPagingInputFormat have the following comment:

      /**
      ...
       *   the number of CQL rows per page
       *   CQLConfigHelper.setInputCQLPageRowSize. The default page row size is 1000. You 
       *   should set it to "as big as possible, but no bigger." It set the LIMIT for the CQL 
       *   query, so you need set it big enough to minimize the network overhead, and also
       *   not too big to avoid out of memory issue.
      ...
      **/
      

      The property is used in both classes, but the default is only set to 1000 in CqlPagingRecordReader explicitly.

      We should either make the default part of the CqlConfigHelper so it's set in both places or update the comments in the CqlInputFormat to say that if it's not set, it will default to the java driver fetch size which is 5000.

      Attachments

        1. CASSANDRA-7269.txt
          0.6 kB
          Rekha Joshi

        Activity

          People

            rekhajoshm Rekha Joshi
            jeromatron Jeremy Hanna
            Rekha Joshi
            Brandon Williams
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: