Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-7202

Update ccm for windows launch script changes from #7001

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: Testing

      Description

      The new .bat launch script changes will require changes to ccm and dtests so we can get windows dtests running on cassci.

        Activity

        Hide
        philipthompson Philip Thompson added a comment -

        Initial ccm pull request proposed at https://github.com/pcmanus/ccm/pull/121

        Show
        philipthompson Philip Thompson added a comment - Initial ccm pull request proposed at https://github.com/pcmanus/ccm/pull/121
        Hide
        JoshuaMcKenzie Joshua McKenzie added a comment -

        2.0.8:

        • command-prompt works
        • cygwin works

        trunk - powershell Unrestricted:

        • command-prompt works
        • cygwin fails:
          cygwin error
          $ ./ccm start
          Traceback (most recent call last):
            File "./ccm", line 72, in <module>
              cmd.run()
            File "/cygdrive/c/vm-shared/src/ptnapCCM/ccm/ccmlib/cmds/cluster_cmds.py", line 423, in run
              if self.cluster.start(no_wait=self.options.no_wait, verbose=self.options.verbose, jvm_args=self.options.jvm_args, profile_options=profile_options) is None:
            File "/cygdrive/c/vm-shared/src/ptnapCCM/ccm/ccmlib/cluster.py", line 229, in start
              p = node.start(update_pid=False, jvm_args=jvm_args, profile_options=profile_options)
            File "/cygdrive/c/vm-shared/src/ptnapCCM/ccm/ccmlib/node.py", line 433, in start
              self._update_pid(process)
            File "/cygdrive/c/vm-shared/src/ptnapCCM/ccm/ccmlib/node.py", line 1074, in _update_pid
              self.pid = int(f.readline().strip().decode('utf-16'))
          UnicodeEncodeError: 'decimal' codec can't encode characters in position 0-1: invalid decimal Unicode string
          

        trunk - powershell Restricted:

        • command-prompt works
        • cygwin fails w/timeout on pid file wait

        From a code perspective, LGTM (and clearly Sylvain as he already merged it ) We still need to integrate the new stop-server.bat functionality to get ctrl+c graceful shutdown from within ccm. I'll see about getting a PR to sylvain w/cygwin cleaned up and the stop-server integration outside this ticket.

        Show
        JoshuaMcKenzie Joshua McKenzie added a comment - 2.0.8: command-prompt works cygwin works trunk - powershell Unrestricted: command-prompt works cygwin fails: cygwin error $ ./ccm start Traceback (most recent call last): File "./ccm" , line 72, in <module> cmd.run() File "/cygdrive/c/vm-shared/src/ptnapCCM/ccm/ccmlib/cmds/cluster_cmds.py" , line 423, in run if self.cluster.start(no_wait=self.options.no_wait, verbose=self.options.verbose, jvm_args=self.options.jvm_args, profile_options=profile_options) is None: File "/cygdrive/c/vm-shared/src/ptnapCCM/ccm/ccmlib/cluster.py" , line 229, in start p = node.start(update_pid=False, jvm_args=jvm_args, profile_options=profile_options) File "/cygdrive/c/vm-shared/src/ptnapCCM/ccm/ccmlib/node.py" , line 433, in start self._update_pid(process) File "/cygdrive/c/vm-shared/src/ptnapCCM/ccm/ccmlib/node.py" , line 1074, in _update_pid self.pid = int (f.readline().strip().decode('utf-16')) UnicodeEncodeError: 'decimal' codec can't encode characters in position 0-1: invalid decimal Unicode string trunk - powershell Restricted: command-prompt works cygwin fails w/timeout on pid file wait From a code perspective, LGTM (and clearly Sylvain as he already merged it ) We still need to integrate the new stop-server.bat functionality to get ctrl+c graceful shutdown from within ccm. I'll see about getting a PR to sylvain w/cygwin cleaned up and the stop-server integration outside this ticket.
        Show
        philipthompson Philip Thompson added a comment - Please also see: https://github.com/pcmanus/ccm/pull/123 https://github.com/riptano/cassandra-dtest/pull/57

          People

          • Assignee:
            philipthompson Philip Thompson
            Reporter:
            philipthompson Philip Thompson
            Reviewer:
            Joshua McKenzie
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development