Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: Testing
    • Labels:

      Description

      Create 2.0->2.1 counter upgrade dtests. Something more extensive, yet more specific than https://github.com/riptano/cassandra-dtest/blob/master/upgrade_through_versions_test.py

        Issue Links

          Activity

          Hide
          rhatch Russ Hatch added a comment -

          With the recent work on the upgrade tests I changed the counters testing there a little bit.

          Now the test creates 100 separate counter cells. These are updated randomly for 15 seconds (so we'll get sorta even distribution of counts across the 100). Then the counts are read back and compared to expected values. On some versions I was running into very slow counter updates which is why I opted for a max time approach instead of a fixed count, though in retrospect maybe those very slow scenarios are worth investigating more.

          Aleksey Yeschenko does this update seem like reasonable coverage, or should we extend it a bit more? Let me know if there's any specifics you'd want to see covered in a test.

          Show
          rhatch Russ Hatch added a comment - With the recent work on the upgrade tests I changed the counters testing there a little bit. Now the test creates 100 separate counter cells. These are updated randomly for 15 seconds (so we'll get sorta even distribution of counts across the 100). Then the counts are read back and compared to expected values. On some versions I was running into very slow counter updates which is why I opted for a max time approach instead of a fixed count, though in retrospect maybe those very slow scenarios are worth investigating more. Aleksey Yeschenko does this update seem like reasonable coverage, or should we extend it a bit more? Let me know if there's any specifics you'd want to see covered in a test.
          Hide
          iamaleksey Aleksey Yeschenko added a comment -

          Russ Hatch Probably. Can you post a link to the commit in question?

          Show
          iamaleksey Aleksey Yeschenko added a comment - Russ Hatch Probably. Can you post a link to the commit in question?
          Show
          rhatch Russ Hatch added a comment - Here's where the changes for counters were introduced: https://github.com/riptano/cassandra-dtest/commit/236c8e3bea19fa5735e067e98756c1fbee9a9162 I may have tweaked it a bit since though. https://github.com/riptano/cassandra-dtest/blob/master/upgrade_through_versions_test.py#L254
          Hide
          iamaleksey Aleksey Yeschenko added a comment -

          Russ Hatch Should probably investigate the 'very slow counter updates' thing before going further. Any ideas/details that you can gather, or should I take over now?

          Show
          iamaleksey Aleksey Yeschenko added a comment - Russ Hatch Should probably investigate the 'very slow counter updates' thing before going further. Any ideas/details that you can gather, or should I take over now?
          Hide
          rhatch Russ Hatch added a comment -

          Aleksey Yeschenko Let me see if I can figure out if the slowness problem is still happening, and on what versions. I think it was on a version prior to 2.1.

          Show
          rhatch Russ Hatch added a comment - Aleksey Yeschenko Let me see if I can figure out if the slowness problem is still happening, and on what versions. I think it was on a version prior to 2.1.
          Hide
          rhatch Russ Hatch added a comment -

          I ran a great many of the upgrade tests today and didn't seen counter update slowness so I think we're ok here.

          Show
          rhatch Russ Hatch added a comment - I ran a great many of the upgrade tests today and didn't seen counter update slowness so I think we're ok here.
          Hide
          iamaleksey Aleksey Yeschenko added a comment -

          Russ Hatch can we switch it back to non-timeboxed approach then? (have a fixed number of counters + counter updates, always), then?

          Show
          iamaleksey Aleksey Yeschenko added a comment - Russ Hatch can we switch it back to non-timeboxed approach then? (have a fixed number of counters + counter updates, always), then?
          Hide
          rhatch Russ Hatch added a comment -

          Test changes made in pull request (pending) at https://github.com/riptano/cassandra-dtest/pull/55

          Show
          rhatch Russ Hatch added a comment - Test changes made in pull request (pending) at https://github.com/riptano/cassandra-dtest/pull/55
          Hide
          iamaleksey Aleksey Yeschenko added a comment -

          LGTM, go ahead.

          Show
          iamaleksey Aleksey Yeschenko added a comment - LGTM, go ahead.

            People

            • Assignee:
              rhatch Russ Hatch
              Reporter:
              iamaleksey Aleksey Yeschenko
              Reviewer:
              Aleksey Yeschenko
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development