[CASSANDRA-6580] Deadcode in AtomicSortedColumns

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.0.5
• Assignee: Sylvain Lebresne
• Reporter: Sylvain Lebresne

Authors

Sylvain Lebresne

Reviewers

Jonathan Ellis

• Created: 14/Jan/14 13:12
• Updated: 16/Apr/19 09:31
• Resolved: 14/Jan/14 14:38

Description

In AtomicSortedColumns we have this:

                  
// for memtable updates we only care about oldcolumn, reconciledcolumn, but when compacting
// we need to make sure we update indexes no matter the order we merge
if (reconciledColumn == column)
    indexer.update(oldColumn, reconciledColumn);
else
    indexer.update(column, reconciledColumn);

This makes no sense anymore however since AtomicSortedColumns is not used anymore during compaction (and index removal is dealt with by the CompactedRow implementations).

Attaching trivial patch against 2.0. This affects 1.2 too and maybe before (haven't check) but it's harmless anyway and we probably won't have much release of pre-2.0 versions anymore. Still, the code is a tad confusing so it's maybe worth cleaning it up in 2.0.