[CASSANDRA-6283] Windows 7 data files kept open / can't be deleted after compaction.

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.0.7, 2.1.0, 2.2.0 beta 1
• Component/s: Legacy/Local Write-Read Paths, Local/Compaction
• Labels: Windows compaction

Environment

Windows 7 (32) / Java 1.7.0.45

• Severity: Normal
• Since Version: 2.0.1
• Assignee: Joshua McKenzie Assign to me
• Reporter: Andreas Schnitzerling

Authors

Joshua McKenzie

Reviewers

Jonathan Ellis

• Created: 01/Nov/13 12:52
• Updated: 16/Apr/19 09:32
• Resolved: 01/May/14 00:11

Description

Files cannot be deleted, patch CASSANDRA-5383 (Win7 deleting problem) doesn't help on Win-7 on Cassandra 2.0.2. Even 2.1 Snapshot is not running. The cause is: Opened file handles seem to be lost and not closed properly. Win 7 blames, that another process is still using the file (but its obviously cassandra). Only restart of the server makes the files deleted. But after heavy using (changes) of tables, there are about 24K files in the data folder (instead of 35 after every restart) and Cassandra crashes. I experiminted and I found out, that a finalizer fixes the problem. So after GC the files will be deleted (not optimal, but working fine). It runs now 2 days continously without problem. Possible fix/test:
I wrote the following finalizer at the end of class org.apache.cassandra.io.util.RandomAccessReader:

RandomAccessReader.java

@Override
protected void finalize() throws Throwable {
	deallocate();
	super.finalize();
}

Can somebody test / develop / patch it? Thx.

Issue Links

• is duplicated by: CASSANDRA-7080 Enhance robustness of snapshot deletions
• is related to: CASSANDRA-5383 Windows 7 deleting/renaming files problem
• is related to: CASSANDRA-4050 Rewrite RandomAccessReader to use FileChannel / nio to address Windows file access violations
• is related to: CASSANDRA-5950 Make snapshot/sequential repair the default
• is related to: CASSANDRA-7541 Windows: IOException when repairing a range of tokens
• relates to: CASSANDRA-3613 Commit Log Test broken on Windows