Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-625

Migrate to slf4j from log4j in cassandra code

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 0.7 beta 1
    • None
    • None
    • all

    Description

      currently code generated from thrift uses slf4j while cassandra uses raw log4j.
      There are various level in which this can be changed:

      • simply switch log4j loggers with slf4j logger (done in patch)
      • replacing log4j-isms (e.g. string concatenation+isFooEnabled in all code paths) with slf4j-isms (marker string + additional arguments)
      • remove code that is already available for lsf4j (LogUtils.java, I believe is unnecessary)

      I am posting this as a reminder, I have a half baked patch locally but it needs more work

      Attachments

        1. CASSANDRA-625-3.patch
          86 kB
          gabriele renzi
        2. CASSANDRA-625-4.patch
          90 kB
          gabriele renzi
        3. CASSANDRA-625-5.patch
          90 kB
          gabriele renzi

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned Assign to me
            riffraff gabriele renzi
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment