Cassandra
  1. Cassandra
  2. CASSANDRA-6047

Memory leak when using snapshot repairs

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.2.10, 2.0.1
    • Component/s: Core
    • Labels:
      None

      Description

      Running nodetool repair repeatedly with the -snapshot parameter results in a native memory leak. The JVM process will take up more and more physical memory until it is killed by the Linux OOM killer.

      The command used was as follows:

      nodetool repair keyspace -local -snapshot -pr -st start_token -et end_token

      Removing the -snapshot flag prevented the memory leak. The subrange repair necessitated multiple repairs, so it made the problem noticeable, but I believe the problem would be reproducible even if you ran repair repeatedly without specifying a start and end token.

      Notes from Yuki Morishita:

      Probably the cause is too many snapshots. Snapshot sstables are opened during validation, but memories used are freed when releaseReferences called. But since snapshots never get marked compacted, memories never freed.

      We only cleanup mmap'd memories when sstable is mark compacted. https://github.com/apache/cassandra/blob/cassandra-1.2/src/java/org/apache/cassandra/io/sstable/SSTableReader.java#L974

      Validation compaction never marks snapshots compacted.

      1. 6047-1.2.txt
        4 kB
        Yuki Morishita

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Yuki Morishita
            Reporter:
            J.B. Langston
            Reviewer:
            Jonathan Ellis
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development