[CASSANDRA-5398] Remove localTimestamp from merkle-tree calculation (for tombstones)

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 1.2.6
• Assignee: Christian Spriegel
• Reporter: Christian Spriegel

Authors

Christian Spriegel

Reviewers

Yuki Morishita

• Created: 28/Mar/13 17:43
• Updated: 16/Apr/19 09:32
• Resolved: 22/May/13 19:10

Description

DeletedColumn and RangeTombstone use the local-timestamp to update the digest during repair.

Even though its only a second-precision timestamp, I think it still causes some differences in the merkle tree, therefore causing overrepair.

I attached a patch on trunk that adds a modified updateDigest() to DeletedColumn, which does not use the value field for its calculation.

Issue Links

• relates to: CASSANDRA-4905 Repair should exclude gcable tombstones from merkle-tree computation
• relates to: CASSANDRA-4917 Optimize tombstone creation for ExpiringColumns
• relates to: CASSANDRA-2698 Instrument repair to be able to assess it's efficiency (precision)