[CASSANDRA-5393] Add retry mechanism to OTC for non-droppable_verbs

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 1.1.12, 1.2.5, 2.0 beta 1
• Severity: Normal
• Assignee: Jason Brown
• Reporter: Jeremiah Jordan

Authors

Jason Brown

Reviewers

Jonathan Ellis

• Created: 27/Mar/13 17:59
• Updated: 16/Apr/19 09:32
• Resolved: 18/Apr/13 20:56

Description

Can we add an Ack/Retry around passing merle tree's around in repair? If the following fails, the repair hangs for ever on the coordinating node.

https://github.com/apache/cassandra/blob/cassandra-1.1.10/src/java/org/apache/cassandra/service/AntiEntropyService.java#L242

            Message message = TreeResponseVerbHandler.makeVerb(local, validator);
            if (!validator.request.endpoint.equals(FBUtilities.getBroadcastAddress()))
                logger.info(String.format("[repair #%s] Sending completed merkle tree to %s for %s", validator.request.sessionid, validator.request.endpoint, validator.request.cf));
            ms.sendOneWay(message, validator.request.endpoint);

If the message asking for merkle tree's gets lost, coordinating node hangs for ever as well.

Issue Links

• depends upon: CASSANDRA-5426 Redesign repair messages