Cassandra
  1. Cassandra
  2. CASSANDRA-5242

Directories.migrateFile() does not handle -old or -tmp LDB manifests

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.1.11
    • Component/s: Core
    • Labels:
      None

      Description

      During LDB compaction a -old.json file is created with the previous manifest.

      Directories.migrateFile() only checks for the .json extension and uses the length to determine the CF name.

      This can result in the -old.json manifest getting copied to a CF-old directory in the new layout.

      see http://www.mail-archive.com/user@cassandra.apache.org/msg27583.html for an example

      1. 0001-CASSANDRA-5242.patch
        2 kB
        Marcus Eriksson
      2. 0001-CASSANDRA-5242-v2.patch
        2 kB
        Marcus Eriksson

        Activity

        Hide
        Jonathan Ellis added a comment -

        Should probably fix even though it's obsolete in 2.0.

        Show
        Jonathan Ellis added a comment - Should probably fix even though it's obsolete in 2.0.
        Hide
        Marcus Eriksson added a comment -

        patch against 1.1

        Show
        Marcus Eriksson added a comment - patch against 1.1
        Hide
        Marcus Eriksson added a comment -

        didnt read title properly it seems, this handles -tmp files as well

        Show
        Marcus Eriksson added a comment - didnt read title properly it seems, this handles -tmp files as well
        Hide
        Jonathan Ellis added a comment -

        Can you review, amorton?

        Show
        Jonathan Ellis added a comment - Can you review, amorton ?
        Hide
        Aleksey Yeschenko added a comment -

        Committed.

        Show
        Aleksey Yeschenko added a comment - Committed.

          People

          • Assignee:
            Marcus Eriksson
            Reporter:
            amorton
            Reviewer:
            Aleksey Yeschenko
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development