Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-5153

max client timestamp

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • 1.1.10, 1.2.1
    • None
    • None
    • Normal

    Description

      1. In public LazilyCompactedRow(CompactionController controller, List<? extends ICountableColumnIterator> rows)
      columnStats = new ColumnStats(reducer == null ? 0 : reducer.columns, reducer == null ? Long.MIN_VALUE : reducer.maxTimestampSeen,
      reducer == null ? new StreamingHistogram(SSTable.TOMBSTONE_HISTOGRAM_BIN_SIZE) : reducer.tombstones

      Tthe maxTimestampSeen should be max(emptyColumnFamily.deletionInfo().maxTimestamp(), reducer.maxTimestampSeen)?

      2. In private ColumnFamily collectTimeOrderedData()
      // if we've already seen a row tombstone with a timestamp greater
      // than the most recent update to this sstable, we're done, since the rest of the sstables
      // will also be older
      if (sstable.getMaxTimestamp() < mostRecentRowTombstone)
      break;
      In the case that sstable.getMaxTimestamp == Long.MIN_VALUE, is it logical?

      Attachments

        1. 5153.txt
          3 kB
          Jonathan Ellis

        Activity

          People

            jbellis Jonathan Ellis
            wy96f Wei Yang
            Jonathan Ellis
            Sylvain Lebresne
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: