Cassandra
  1. Cassandra
  2. CASSANDRA-5051

Allow automatic cleanup after gc_grace

    Details

    • Type: New Feature New Feature
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Fix Version/s: 3.0
    • Component/s: Core
    • Labels:

      Description

      When using vnodes, after adding a new node you have to run cleanup on all the machines, because you don't know which are affected and chances are it was most if not all of them. As an alternative to this intensive process, we could allow cleanup during compaction if the data is older than gc_grace (or perhaps some other time period since people tend to use gc_grace hacks to get rid of tombstones.)

      1. 0001-CASSANDRA-5051.patch
        17 kB
        Vijay
      2. 5051-v2.txt
        12 kB
        Jonathan Ellis
      3. 0001-5051-with-test-fixes.patch
        23 kB
        Vijay
      4. 0002-5051-remove-upgradesstable.patch
        9 kB
        Vijay
      5. 0001-5051-v4.patch
        24 kB
        Vijay
      6. 0002-5051-remove-upgradesstable-v4.patch
        9 kB
        Vijay
      7. 0004-5051-additional-test-v4.patch
        4 kB
        Vijay
      8. 0001-5051-v6.patch
        41 kB
        Vijay

        Issue Links

          Activity

          Brandon Williams created issue -
          Gavin made changes -
          Field Original Value New Value
          Workflow no-reopen-closed, patch-avail [ 12741734 ] patch-available, re-open possible [ 12753744 ]
          Gavin made changes -
          Workflow patch-available, re-open possible [ 12753744 ] reopen-resolved, no closed status, patch-avail, testing [ 12758863 ]
          Jonathan Ellis made changes -
          Assignee Vijay [ vijay2win@yahoo.com ]
          Vijay made changes -
          Attachment 0001-CASSANDRA-5051.patch [ 12569772 ]
          Vijay made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jonathan Ellis made changes -
          Reviewer jbellis
          Jonathan Ellis made changes -
          Attachment 3430-v3.txt [ 12570312 ]
          Jonathan Ellis made changes -
          Comment [ v3 adds an extra assert that is failing in CompactionsTest. Not sure why.

          {code}
          . CompactionManager.instance.interruptCompactionFor(Collections.singleton(metadata));
                          while (CompactionManager.instance.isCompacting(metadata))
                              FBUtilities.sleep(100);

                          assert data.getCompacting().isEmpty();
          {code} ]
          Jonathan Ellis made changes -
          Attachment 3430-v3.txt [ 12570312 ]
          Jonathan Ellis made changes -
          Attachment 5051-v2.txt [ 12571590 ]
          Jonathan Ellis made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Vijay made changes -
          Attachment 0001-5051-with-test-fixes.patch [ 12573028 ]
          Attachment 0002-5051-remove-upgradesstable.patch [ 12573029 ]
          Vijay made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Vijay made changes -
          Attachment 0001-5051-v4.patch [ 12573168 ]
          Attachment 0002-5051-remove-upgradesstable-v4.patch [ 12573169 ]
          Vijay made changes -
          Attachment 0004-5051-additional-test-v4.patch [ 12573634 ]
          Jonathan Ellis made changes -
          Link This issue is duplicated by CASSANDRA-3526 [ CASSANDRA-3526 ]
          Anonymous made changes -
          Status Patch Available [ 10002 ] Testing [ 10012 ]
          Brandon Williams made changes -
          Status Testing [ 10012 ] Open [ 1 ]
          Vijay made changes -
          Attachment 0001-5051-v6.patch [ 12580251 ]
          Jonathan Ellis made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jonathan Ellis made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jonathan Ellis made changes -
          Fix Version/s 2.1 [ 12324159 ]
          Fix Version/s 2.0 [ 12322954 ]
          Sylvain Lebresne made changes -
          Fix Version/s 2.1 beta2 [ 12326276 ]
          Fix Version/s 2.1 [ 12324159 ]
          Sylvain Lebresne made changes -
          Fix Version/s 2.1 rc1 [ 12326658 ]
          Fix Version/s 2.1 beta2 [ 12326276 ]
          Jonathan Ellis made changes -
          Fix Version/s 3.0 [ 12324945 ]
          Fix Version/s 2.1 rc1 [ 12326658 ]

            People

            • Assignee:
              Vijay
              Reporter:
              Brandon Williams
              Reviewer:
              Jonathan Ellis
            • Votes:
              2 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:

                Development