[CASSANDRA-488] TcpConnectionManager only ever has one connection

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 0.5
• Assignee: Gary Dusbabek
• Reporter: Jonathan Ellis

Authors

Gary Dusbabek

• Created: 14/Oct/09 17:45
• Updated: 16/Apr/19 09:33
• Resolved: 09/Nov/09 16:56

Description

from irc:

jbellis: am i missing something? it looks like TcpConnectionManager.allConnections_ will only ever contain a single TcpConnection, since before adding any connection it checks contains() first, which relies on TcpConn.equals, which reports that any TcpConns w/ same local & remote endpoints are equal

junrao: yes, TcpConnectionManager.allConnections_ can have no more than 1 element.

jbellis: that might explain why it's so easy to swamp things and start getting timeouts – if all your connections are full of command data, "success" replies will have to wait for those to drain out first before being sent

IMO the Right Design is one connection for commands, one connection for acks/replies, rather than a single pool of connections for everything. that way a connection from A -> B "full" of outgoing commands can't block replies from A -> B acking commands that came the other way.