Cassandra
  1. Cassandra
  2. CASSANDRA-4772

HintedHandoff fails to deliver hints after first repaired node

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 1.1.6
    • Component/s: None
    • Labels:

      Description

      If some node has hints for a few nodes it will deliver hints only for the first one of them. After all hints delivery for the first node compaction process is started. After compaction all data from hints cf is removed.

      target fix for 1.2 version:

      diff --git a/src/java/org/apache/cassandra/db/HintedHandOffManager.java b/src/java/org/apache/cassandra/db/HintedHandOffManager.java
      index e5ff163..c02997e 100644
      --- a/src/java/org/apache/cassandra/db/HintedHandOffManager.java
      +++ b/src/java/org/apache/cassandra/db/HintedHandOffManager.java
      @@ -189,7 +189,7 @@ public class HintedHandOffManager implements HintedHandOffManagerMBean
               ArrayList<Descriptor> descriptors = new ArrayList<Descriptor>();
               for (SSTable sstable : hintStore.getSSTables())
                   descriptors.add(sstable.descriptor);
      -        return CompactionManager.instance.submitUserDefined(hintStore, descriptors, Integer.MAX_VALUE);
      +        return CompactionManager.instance.submitUserDefined(hintStore, descriptors, (int) System.currentTimeMillis() / 1000);
           }
      
       
           private static boolean pagingFinished(ColumnFamily hintColumnFamily, ByteBuffer startColumn)
      

      Can I expect to see that fix in 1.1.6 version?

      1. 4772-1.0.txt
        4 kB
        Jonathan Ellis
      2. cassandra-1.2-4772-hh_compact.txt
        4 kB
        Alexey Zotov

        Issue Links

          Activity

            People

            • Assignee:
              Alexey Zotov
              Reporter:
              Alexey Zotov
              Reviewer:
              Jonathan Ellis
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development