Cassandra
  1. Cassandra
  2. CASSANDRA-4753

Timeout reporter writes hints for the local node

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.2.1
    • Component/s: None
    • Labels:
      None

      Description

      MessagingService.java:330 calls StorageProxy.scheduleLocalHint() without checking if the local node is the target. This causes StorageProxy.scheduleLocalHint to throw AssertionError sometimes.

      Got this error when some batches are timed out. This can happen because even local batches now go through StorageProxy.sendMessages and aren't just rm.apply()'d.

      1. 4753-v3.txt
        2 kB
        Aleksey Yeschenko
      2. 4753-v2.txt
        2 kB
        Jonathan Ellis
      3. 4753.txt
        0.8 kB
        Aleksey Yeschenko

        Activity

        Aleksey Yeschenko created issue -
        Jonathan Ellis made changes -
        Field Original Value New Value
        Fix Version/s 1.2.0 [ 12323243 ]
        Fix Version/s 1.2.0 beta 2 [ 12323284 ]
        Jonathan Ellis made changes -
        Assignee Jonathan Ellis [ jbellis ] Aleksey Yeschenko [ iamaleksey ]
        Reviewer jbellis
        Aleksey Yeschenko made changes -
        Attachment 4753.txt [ 12554108 ]
        Aleksey Yeschenko made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Jonathan Ellis made changes -
        Attachment 4753-v2.txt [ 12554140 ]
        Aleksey Yeschenko made changes -
        Attachment 4753-v3.txt [ 12554154 ]
        Jonathan Ellis made changes -
        Comment [ Here is one solution.

        - Created LocalMutationRunnable that retries with hint backpressure if it gets dropped
        - Added an updated v3, with an additional assert to make sure we don't introduce a bug if we decide to allow using the coordinator as a batchlog member in non-single-node clusters ]
        Jonathan Ellis made changes -
        Assignee Aleksey Yeschenko [ iamaleksey ] Jonathan Ellis [ jbellis ]
        Fix Version/s 1.2.1 [ 12322953 ]
        Fix Version/s 1.2.0 [ 12323243 ]
        Reviewer jbellis iamaleksey
        Jonathan Ellis made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Jonathan Ellis made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12728083 ] patch-available, re-open possible [ 12753314 ]
        Gavin made changes -
        Workflow patch-available, re-open possible [ 12753314 ] reopen-resolved, no closed status, patch-avail, testing [ 12758686 ]

          People

          • Assignee:
            Jonathan Ellis
            Reporter:
            Aleksey Yeschenko
            Reviewer:
            Aleksey Yeschenko
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development