[CASSANDRA-4656] StorageProxy histograms

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 1.1.6
• Assignee: Aleksei Zotov Assign to me
• Reporter: Aleksei Zotov

Authors

Aleksei Zotov

Reviewers

Brandon Williams

• Created: 12/Sep/12 14:12
• Updated: 16/Apr/19 09:32
• Resolved: 19/Sep/12 11:17

Description

I suggest to do two improvements:
1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).

2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.

Old output:

Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597                                 0               505                 0                 0
1916                                 0               566                 0                 0

New output:

Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597               0                 0               505                 0                 0
1916               0                 0               566                 0                 0

PS: I've attached a patch that fixes all described problems.