[CASSANDRA-4308] Promote the use of IFilter for internal commands

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 1.2.0 beta 1
• Assignee: Sylvain Lebresne
• Reporter: Sylvain Lebresne

Authors

Sylvain Lebresne

Reviewers

Yuki Morishita

• Created: 05/Jun/12 13:57
• Updated: 16/Apr/19 09:32
• Resolved: 08/Jun/12 07:33

Description

All read commands (the IReadCommand) work on slice and names filters, but none of them uses the SliceQueryFilter and NamesQueryFilter classes (RangeSliceCommand uses SlicePrediate from thrift and

{SliceFrom, SliceByNames}

ReadReadCommand interns the arguments).

The main problem of that is that it follows that those command don't share the serialization code for the column filters. Which isn't good for code reuse, but also makes it a pain to add new fields to the filter SliceQueryFilter (which CASSANDRA-3885 will need, but probably CASSANDRA-3647 too).