Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-3559

CFMetaData conversions to Thrift/Native schema should be inverse one of the other

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:

      Description

      In other word, it would probably be a good idea to have:

        cfm == CFMetadata.fromThrift(cfm.toThrift())
        cfm == CFMetadata.fromSchema(cfm.toSchema())
      

      In particular, we could have unit tests to check that, which would avoid things like CASSANDRA-3558.

      It is not the case today for thrift because of the keyAlias. For some reason, if the keyAlias is not set, we return with toThrift() the default alias. I don't think this serves any purpose though.

        Attachments

        1. 3559-v3.patch
          13 kB
          Sylvain Lebresne
        2. CASSANDRA-3559-v2.patch
          3 kB
          Pavel Yaskevich
        3. 3559.patch
          4 kB
          Sylvain Lebresne

          Activity

            People

            • Assignee:
              slebresne Sylvain Lebresne
              Reporter:
              slebresne Sylvain Lebresne
              Reviewer:
              Pavel Yaskevich
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: