Cassandra
  1. Cassandra
  2. CASSANDRA-3534

Remove memory emergency pressure valve

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 2.0 beta 1
    • Component/s: Core
    • Labels:
      None

      Description

      Seems like when these thresholds are reached we are trying to reduce the keycache and Memtable sizes, but in the trunk memtable is moved off-heap hence reducing that will not actually help.
      Reducing the keycache might help but we might want to provide a way to bring the cache level back to the configured value when the pressure goes away.

      Conversation from IRC: we might want to remove these setting all together after global keycache.

      1. 3534.txt
        12 kB
        Aleksey Yeschenko

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          470d 22h 19m 1 Aleksey Yeschenko 11/Mar/13 00:18
          Patch Available Patch Available Resolved Resolved
          16h 7m 1 Aleksey Yeschenko 11/Mar/13 16:26
          Jonathan Ellis made changes -
          Summary Enhance or remove memory emergency pressure valve Remove memory emergency pressure valve
          Aleksey Yeschenko made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Aleksey Yeschenko added a comment -

          Thanks, committed (with removed reduceCacheSizes()).

          Show
          Aleksey Yeschenko added a comment - Thanks, committed (with removed reduceCacheSizes()).
          Hide
          Jonathan Ellis added a comment -

          +1. I'd also be fine with just removing reduceCacheSizes instead of leaving it as a no-op.

          Show
          Jonathan Ellis added a comment - +1. I'd also be fine with just removing reduceCacheSizes instead of leaving it as a no-op.
          Aleksey Yeschenko made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Reviewer jbellis
          Aleksey Yeschenko made changes -
          Attachment 3534.txt [ 12573002 ]
          Jonathan Ellis made changes -
          Assignee Aleksey Yeschenko [ iamaleksey ]
          Gavin made changes -
          Workflow patch-available, re-open possible [ 12753050 ] reopen-resolved, no closed status, patch-avail, testing [ 12755706 ]
          Gavin made changes -
          Workflow no-reopen-closed, patch-avail [ 12643486 ] patch-available, re-open possible [ 12753050 ]
          Jonathan Ellis made changes -
          Summary Enhance memory emergency pressure valve Enhance or remove memory emergency pressure valve
          Fix Version/s 2.0 [ 12322954 ]
          Vijay made changes -
          Assignee Vijay [ vijay2win@yahoo.com ]
          Vijay made changes -
          Field Original Value New Value
          Link This issue is blocked by CASSANDRA-3143 [ CASSANDRA-3143 ]
          Hide
          Jonathan Ellis added a comment -

          Then you will be able to say "use X amount of memory for memtables, Y amount for the cache (and monitor Z amount for the bloom filters)" which makes the old "pressure valve" code obsolete.

          Show
          Jonathan Ellis added a comment - Then you will be able to say "use X amount of memory for memtables, Y amount for the cache (and monitor Z amount for the bloom filters)" which makes the old "pressure valve" code obsolete.
          Hide
          Jonathan Ellis added a comment -

          Yes, I think the right approach is to remove this code once CASSANDRA-3143 is done.

          Show
          Jonathan Ellis added a comment - Yes, I think the right approach is to remove this code once CASSANDRA-3143 is done.
          Vijay created issue -

            People

            • Assignee:
              Aleksey Yeschenko
              Reporter:
              Vijay
              Reviewer:
              Jonathan Ellis
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development