Cassandra
  1. Cassandra
  2. CASSANDRA-3534

Remove memory emergency pressure valve

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 2.0 beta 1
    • Component/s: Core
    • Labels:
      None

      Description

      Seems like when these thresholds are reached we are trying to reduce the keycache and Memtable sizes, but in the trunk memtable is moved off-heap hence reducing that will not actually help.
      Reducing the keycache might help but we might want to provide a way to bring the cache level back to the configured value when the pressure goes away.

      Conversation from IRC: we might want to remove these setting all together after global keycache.

      1. 3534.txt
        12 kB
        Aleksey Yeschenko

        Issue Links

          Activity

          Hide
          Jonathan Ellis added a comment -

          Yes, I think the right approach is to remove this code once CASSANDRA-3143 is done.

          Show
          Jonathan Ellis added a comment - Yes, I think the right approach is to remove this code once CASSANDRA-3143 is done.
          Hide
          Jonathan Ellis added a comment -

          Then you will be able to say "use X amount of memory for memtables, Y amount for the cache (and monitor Z amount for the bloom filters)" which makes the old "pressure valve" code obsolete.

          Show
          Jonathan Ellis added a comment - Then you will be able to say "use X amount of memory for memtables, Y amount for the cache (and monitor Z amount for the bloom filters)" which makes the old "pressure valve" code obsolete.
          Hide
          Jonathan Ellis added a comment -

          +1. I'd also be fine with just removing reduceCacheSizes instead of leaving it as a no-op.

          Show
          Jonathan Ellis added a comment - +1. I'd also be fine with just removing reduceCacheSizes instead of leaving it as a no-op.
          Hide
          Aleksey Yeschenko added a comment -

          Thanks, committed (with removed reduceCacheSizes()).

          Show
          Aleksey Yeschenko added a comment - Thanks, committed (with removed reduceCacheSizes()).

            People

            • Assignee:
              Aleksey Yeschenko
              Reporter:
              Vijay
              Reviewer:
              Jonathan Ellis
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development