Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Fix Version/s: 1.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Another problem with sstable deletions on 1.0. Running scrub produces lot of unable to delete messages on windows.

      ERROR 16:16:37,562 Unable to delete \var\lib\cassandra\data\test\sipdb-h-711-Dat
      a.db (it will be removed on server restart; we'll also retry after GC)
      INFO 16:16:37,577 Scrub of SSTableReader(path='\var\lib\cassandra\data\test\sip
      db-h-711-Data.db') complete: 48396 rows in new sstable and 0 empty (tombstoned)
      rows dropped

      1. 3318.txt
        17 kB
        Jonathan Ellis

        Activity

        Hide
        jbellis Jonathan Ellis added a comment -

        committed

        Show
        jbellis Jonathan Ellis added a comment - committed
        Hide
        jbellis Jonathan Ellis added a comment -

        I'm only going to commit this to 1.0 after all, because before that our PhantomReference-based deleting is very unlikely to run into this problem, so I'm going to let the stable releases stay stable.

        Show
        jbellis Jonathan Ellis added a comment - I'm only going to commit this to 1.0 after all, because before that our PhantomReference-based deleting is very unlikely to run into this problem, so I'm going to let the stable releases stay stable.
        Hide
        slebresne Sylvain Lebresne added a comment -

        +1

        Show
        slebresne Sylvain Lebresne added a comment - +1
        Hide
        jbellis Jonathan Ellis added a comment -

        (patch is against trunk)

        Show
        jbellis Jonathan Ellis added a comment - (patch is against trunk)
        Hide
        jbellis Jonathan Ellis added a comment - - edited

        that means it's the sstable from before scrub.

        patch attached to close the readers before replacing the old sstable with the new one.

        (the diff is intimidating but it's mostly indentation changes from combining two try/finally blocks. recommend using a "smart" diff tool like intellij's, post-patch application.)

        Show
        jbellis Jonathan Ellis added a comment - - edited that means it's the sstable from before scrub. patch attached to close the readers before replacing the old sstable with the new one. (the diff is intimidating but it's mostly indentation changes from combining two try/finally blocks. recommend using a "smart" diff tool like intellij's, post-patch application.)
        Hide
        hsn Radim Kolar added a comment -

        INFO 23:05:39,845 Scrub of SSTableReader(path='\var\lib\cassandra\data\system\S
        chema-h-10-Data.db') complete: 8 rows in new sstable and 0 empty (tombstoned) ro
        ws dropped
        ERROR 23:05:39,845 Unable to delete \var\lib\cassandra\data\system\Schema-h-10-D
        ata.db (it will be removed on server restart; we'll also retry after GC)

        its table after scrub is finished.

        Show
        hsn Radim Kolar added a comment - INFO 23:05:39,845 Scrub of SSTableReader(path='\var\lib\cassandra\data\system\S chema-h-10-Data.db') complete: 8 rows in new sstable and 0 empty (tombstoned) ro ws dropped ERROR 23:05:39,845 Unable to delete \var\lib\cassandra\data\system\Schema-h-10-D ata.db (it will be removed on server restart; we'll also retry after GC) its table after scrub is finished.
        Hide
        jbellis Jonathan Ellis added a comment -

        Suspect this also affects 0.7 and 0.8.

        Show
        jbellis Jonathan Ellis added a comment - Suspect this also affects 0.7 and 0.8.
        Hide
        jbellis Jonathan Ellis added a comment -

        Is 711 a pre-scrub or post-scrub sstable?

        Show
        jbellis Jonathan Ellis added a comment - Is 711 a pre-scrub or post-scrub sstable?

          People

          • Assignee:
            jbellis Jonathan Ellis
            Reporter:
            hsn Radim Kolar
            Reviewer:
            Sylvain Lebresne
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development