[CASSANDRA-3223] probably don't need to do full copy to row cache after un-mmap() change

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Severity: Low
• Assignee: Yang Yang
• Reporter: Yang Yang

Authors

Yang Yang

Reviewers

Jonathan Ellis

• Created: 17/Sep/11 00:31
• Updated: 16/Apr/19 09:32
• Resolved: 18/Sep/11 04:51

Description

3179 changes from directly using the bytebuffer from mmap(), to copying that buffer,

CFS.cacheRow() https://github.com/apache/cassandra/blob/cassandra-1.0.0/src/java/org/apache/cassandra/db/ColumnFamilyStore.java line 1126
says it makes a deep copy exactly to prevent issues from unmmap().

maybe this deep copy is not needed now given 3179

if so, maybe slightly better performance in both speed and memory