Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-3158

Improve caching of same-version Messages on digest and repair paths

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Fix Version/s: 0.8.6
    • Component/s: None
    • Labels:
      None
    1. 3158-v2.txt
      4 kB
      Jonathan Ellis
    2. 3158.txt
      1 kB
      Jonathan Ellis

      Activity

      Hide
      jbellis Jonathan Ellis added a comment -

      v2 also lazy-initializes the caching producer for the initial digest reads, and updates comments

      Show
      jbellis Jonathan Ellis added a comment - v2 also lazy-initializes the caching producer for the initial digest reads, and updates comments
      Hide
      slebresne Sylvain Lebresne added a comment -

      For the initial digest reads, it would be nice to use the CachingMessageProducer for the local digest read too.

      Show
      slebresne Sylvain Lebresne added a comment - For the initial digest reads, it would be nice to use the CachingMessageProducer for the local digest read too.
      Hide
      jbellis Jonathan Ellis added a comment -

      no Messages are created for local reads.

      Show
      jbellis Jonathan Ellis added a comment - no Messages are created for local reads.
      Hide
      slebresne Sylvain Lebresne added a comment -

      Oh right, my bad. Anyways, lgtm, +1.

      Show
      slebresne Sylvain Lebresne added a comment - Oh right, my bad. Anyways, lgtm, +1.
      Hide
      jbellis Jonathan Ellis added a comment -

      committed

      Show
      jbellis Jonathan Ellis added a comment - committed
      Hide
      jbellis Jonathan Ellis added a comment -

      Note that on merge to trunk I also added a readCallbacks.clear() statement at the beginning of the short-read do/while loop.

      Show
      jbellis Jonathan Ellis added a comment - Note that on merge to trunk I also added a readCallbacks.clear() statement at the beginning of the short-read do/while loop.
      Hide
      hudson Hudson added a comment -

      Integrated in Cassandra-0.8 #321 (See https://builds.apache.org/job/Cassandra-0.8/321/)
      Improve caching of same-version Messages on digest and repair paths
      patch by jbellis; reviewed by slebresne for CASSANDRA-3158

      jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166774
      Files :

      • /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageProxy.java
      Show
      hudson Hudson added a comment - Integrated in Cassandra-0.8 #321 (See https://builds.apache.org/job/Cassandra-0.8/321/ ) Improve caching of same-version Messages on digest and repair paths patch by jbellis; reviewed by slebresne for CASSANDRA-3158 jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166774 Files : /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageProxy.java

        People

        • Assignee:
          jbellis Jonathan Ellis
          Reporter:
          jbellis Jonathan Ellis
          Reviewer:
          Sylvain Lebresne
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development