[CASSANDRA-3084] o.a.c.dht.Range.differenceToFetch() doesn't handle all cases correctly

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 0.8.5
• Severity: Normal
• Assignee: Tom Hobbs
• Reporter: Tom Hobbs

Authors

Tom Hobbs

Reviewers

Stu Hood

• Created: 26/Aug/11 19:06
• Updated: 16/Apr/19 09:32
• Resolved: 30/Aug/11 05:50

Description

It's possible that differenceToFetch is making implicit assumptions about the relationship between the two ranges, but the following cases are not handled correctly (the old range is (A, B], the new is (C, D]:

--C--A-----B--D--

Here, the result will be (C, A] and (D, B], instead of (C, A] and (B, D].

--C--A-----D--B--

The result will be (C, D] instead of just (C, A].

--A--C-----D--B--

The result will be (B, D] when nothing needs to be transfered.

If there is some kind of implicit assumption that these cases won't arise, it either needs to be explicit (assertions, exceptions) or the cases need to be handled. It should be easy to cover this with unit tests.