Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 0.4
    • Component/s: Core
    • Labels:
      None

      Activity

      Hide
      Hudson added a comment -

      Integrated in Cassandra #119 (See http://hudson.zones.apache.org/hudson/job/Cassandra/119/)
      cleanup CFS.onstart
      patch by jbellis; reviewed by Jun Rao for
      DBManager obscures rather than clarifies what is going on. Remove it.

      At some point we stopped calling DBManager.instance(), so Table.onStart was
      not getting called. Move that into CassandraDaemon so we don't rely on a side
      effect to run it.

      patch by jbellis; reviewed by Jun Rao for
      use normal Table for system metadata
      patch by jbellis; reviewed by Jun Rao for
      r/m recycle cf and undocumented/incomplete Loader code using it
      patch by jbellis; reviewed by Jun Rao for
      move Hints cf to SYSTEM_TABLE
      patch by jbellis; reviewed by Jun Rao for

      Show
      Hudson added a comment - Integrated in Cassandra #119 (See http://hudson.zones.apache.org/hudson/job/Cassandra/119/ ) cleanup CFS.onstart patch by jbellis; reviewed by Jun Rao for DBManager obscures rather than clarifies what is going on. Remove it. At some point we stopped calling DBManager.instance(), so Table.onStart was not getting called. Move that into CassandraDaemon so we don't rely on a side effect to run it. patch by jbellis; reviewed by Jun Rao for use normal Table for system metadata patch by jbellis; reviewed by Jun Rao for r/m recycle cf and undocumented/incomplete Loader code using it patch by jbellis; reviewed by Jun Rao for move Hints cf to SYSTEM_TABLE patch by jbellis; reviewed by Jun Rao for
      Hide
      Jonathan Ellis added a comment -

      committed

      Show
      Jonathan Ellis added a comment - committed
      Hide
      Jun Rao added a comment -

      The patch looks fine to me.

      Show
      Jun Rao added a comment - The patch looks fine to me.
      Hide
      Jonathan Ellis added a comment -

      deleted old patches and uploaded new

      Show
      Jonathan Ellis added a comment - deleted old patches and uploaded new
      Hide
      Jun Rao added a comment -

      I can't apply 0002 cleanly to trunk. Could you rebase? Thanks,

      Show
      Jun Rao added a comment - I can't apply 0002 cleanly to trunk. Could you rebase? Thanks,
      Hide
      Jonathan Ellis added a comment -

      Note that for the hints we are using one row per table, whereas before we did not record table info in the hints cf.

      Show
      Jonathan Ellis added a comment - Note that for the hints we are using one row per table, whereas before we did not record table info in the hints cf.
      Hide
      Jonathan Ellis added a comment -

      commit message for 04 reads

      DBManager obscures rather than clarifies what is going on. Remove it.

      At some point in the we stopped calling DBManager.instance(), so Table.onStart was
      not getting called. Move that into CassandraDaemon so we don't rely on a side
      effect to run it.

      the others are visible in the filename.

      Show
      Jonathan Ellis added a comment - commit message for 04 reads DBManager obscures rather than clarifies what is going on. Remove it. At some point in the we stopped calling DBManager.instance(), so Table.onStart was not getting called. Move that into CassandraDaemon so we don't rely on a side effect to run it. the others are visible in the filename.

        People

        • Assignee:
          Jonathan Ellis
          Reporter:
          Jonathan Ellis
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development