Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 0.4
    • Component/s: Core
    • Labels:
      None

      Activity

      Jonathan Ellis created issue -
      Jonathan Ellis made changes -
      Field Original Value New Value
      Assignee Jonathan Ellis [ jbellis ]
      Fix Version/s 0.4 [ 12313862 ]
      Jonathan Ellis made changes -
      Attachment 0001-CASSANDRA-235-move-Hints-cf-to-SYSTEM_TABLE.txt [ 12411460 ]
      Attachment 0002-r-m-recycle-cf-and-undocumented-incomplete-Loader-code.txt [ 12411461 ]
      Attachment 0003-use-normal-Table-for-system-metadata.txt [ 12411462 ]
      Attachment 0004-DBManager-obscures-rather-than-clarifies-what-is-going.txt [ 12411463 ]
      Attachment 0005-cleanup-CFS.onstart.txt [ 12411464 ]
      Hide
      Jonathan Ellis added a comment -

      commit message for 04 reads

      DBManager obscures rather than clarifies what is going on. Remove it.

      At some point in the we stopped calling DBManager.instance(), so Table.onStart was
      not getting called. Move that into CassandraDaemon so we don't rely on a side
      effect to run it.

      the others are visible in the filename.

      Show
      Jonathan Ellis added a comment - commit message for 04 reads DBManager obscures rather than clarifies what is going on. Remove it. At some point in the we stopped calling DBManager.instance(), so Table.onStart was not getting called. Move that into CassandraDaemon so we don't rely on a side effect to run it. the others are visible in the filename.
      Hide
      Jonathan Ellis added a comment -

      Note that for the hints we are using one row per table, whereas before we did not record table info in the hints cf.

      Show
      Jonathan Ellis added a comment - Note that for the hints we are using one row per table, whereas before we did not record table info in the hints cf.
      Hide
      Jun Rao added a comment -

      I can't apply 0002 cleanly to trunk. Could you rebase? Thanks,

      Show
      Jun Rao added a comment - I can't apply 0002 cleanly to trunk. Could you rebase? Thanks,
      Jonathan Ellis made changes -
      Attachment 0001-CASSANDRA-235-move-Hints-cf-to-SYSTEM_TABLE.txt [ 12411460 ]
      Jonathan Ellis made changes -
      Attachment 0002-r-m-recycle-cf-and-undocumented-incomplete-Loader-code.txt [ 12411461 ]
      Jonathan Ellis made changes -
      Attachment 0003-use-normal-Table-for-system-metadata.txt [ 12411462 ]
      Jonathan Ellis made changes -
      Attachment 0004-DBManager-obscures-rather-than-clarifies-what-is-going.txt [ 12411463 ]
      Jonathan Ellis made changes -
      Attachment 0005-cleanup-CFS.onstart.txt [ 12411464 ]
      Hide
      Jonathan Ellis added a comment -

      deleted old patches and uploaded new

      Show
      Jonathan Ellis added a comment - deleted old patches and uploaded new
      Hide
      Jun Rao added a comment -

      The patch looks fine to me.

      Show
      Jun Rao added a comment - The patch looks fine to me.
      Hide
      Jonathan Ellis added a comment -

      committed

      Show
      Jonathan Ellis added a comment - committed
      Jonathan Ellis made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Hide
      Hudson added a comment -

      Integrated in Cassandra #119 (See http://hudson.zones.apache.org/hudson/job/Cassandra/119/)
      cleanup CFS.onstart
      patch by jbellis; reviewed by Jun Rao for
      DBManager obscures rather than clarifies what is going on. Remove it.

      At some point we stopped calling DBManager.instance(), so Table.onStart was
      not getting called. Move that into CassandraDaemon so we don't rely on a side
      effect to run it.

      patch by jbellis; reviewed by Jun Rao for
      use normal Table for system metadata
      patch by jbellis; reviewed by Jun Rao for
      r/m recycle cf and undocumented/incomplete Loader code using it
      patch by jbellis; reviewed by Jun Rao for
      move Hints cf to SYSTEM_TABLE
      patch by jbellis; reviewed by Jun Rao for

      Show
      Hudson added a comment - Integrated in Cassandra #119 (See http://hudson.zones.apache.org/hudson/job/Cassandra/119/ ) cleanup CFS.onstart patch by jbellis; reviewed by Jun Rao for DBManager obscures rather than clarifies what is going on. Remove it. At some point we stopped calling DBManager.instance(), so Table.onStart was not getting called. Move that into CassandraDaemon so we don't rely on a side effect to run it. patch by jbellis; reviewed by Jun Rao for use normal Table for system metadata patch by jbellis; reviewed by Jun Rao for r/m recycle cf and undocumented/incomplete Loader code using it patch by jbellis; reviewed by Jun Rao for move Hints cf to SYSTEM_TABLE patch by jbellis; reviewed by Jun Rao for
      Michael Greene made changes -
      Component/s Core [ 12312978 ]
      Gavin made changes -
      Workflow no-reopen-closed, patch-avail [ 12466061 ] patch-available, re-open possible [ 12749934 ]
      Gavin made changes -
      Workflow patch-available, re-open possible [ 12749934 ] reopen-resolved, no closed status, patch-avail, testing [ 12754504 ]
      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Open Open Resolved Resolved
      7d 16h 19m 1 Jonathan Ellis 24/Jun/09 20:24

        People

        • Assignee:
          Jonathan Ellis
          Reporter:
          Jonathan Ellis
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development