[CASSANDRA-2213] A bug in BufferedRandomAccessFile

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 0.7.3
• Severity: Normal
• Assignee: Leo Jay
• Reporter: Leo Jay

Authors

Leo Jay

Reviewers

Jonathan Ellis

• Created: 22/Feb/11 09:15
• Updated: 16/Apr/19 09:33
• Resolved: 22/Feb/11 18:04

Description

The first line of BufferedRandomAccessFile.readAtMost is

if (length >= bufferEnd && hitEOF)

I think It should be ">" instead of ">=",
Here is a test for this:

    @Test
    public void testRead() throws IOException {
        File tmpFile = File.createTempFile("readtest", "bin");
        tmpFile.deleteOnExit();

        // Create the BRAF by filename instead of by file.
        BufferedRandomAccessFile rw = new BufferedRandomAccessFile(tmpFile.getPath(), "rw");
        rw.write(new byte[] {1});

        rw.seek(0);
        byte[] buffer = new byte[1];
        assert rw.read(buffer) == 1;
        assert buffer[0] == 1;
}