[CASSANDRA-20146] Check presence of a snapshot in a case-insensitive manner on macOS platform to prevent hardlinking failures

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.1
• Component/s: Local/Snapshots, Test/dtest/java
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: DTest
• Platform: ARM
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/75ec1ada7a40761e8b6eb948925c2dd2b116876e

Test and Documentation Plan

CI will be run and manual verification on a Mac OS will be conducted

• Assignee: Stefan Miklosovic
• Reporter: Caleb Rackliffe

Authors

Stefan Miklosovic

Reviewers

Bernardo Botella, Caleb Rackliffe

• Created: 4 days ago 17:19
• Updated: 3 days ago 09:17
• Resolved: 3 days ago 09:17

Description

It looks like snapshot names are perhaps not case-sensitive, and there is a collision between "snapshot" and "Snapshot". In the logs, I see this when I run testExoticSnapshotNames():

WARN  16:45:44 Unable to create snapshot Snapshot for distributed_test_keyspace.tbl
java.lang.RuntimeException: Tried to create duplicate hard link to /private/var/folders/4d/zfjs7m7s6x5_l93k33r5k6680000gn/T/dtests17605712756058855626/node1/data2/distributed_test_keyspace/tbl-1b255f4def2540a60000000000000005/snapshots/Snapshot/oa-3-big-Data.db
	at org.apache.cassandra.io.util.FileUtils.createHardLink(FileUtils.java:174)
	at org.apache.cassandra.io.sstable.format.SSTableReader.createLinks(SSTableReader.java:1114)
	at org.apache.cassandra.io.sstable.format.SSTableReader.createLinks(SSTableReader.java:1096)
	at org.apache.cassandra.service.snapshot.TakeSnapshotTask.createSnapshot(TakeSnapshotTask.java:166)
	at org.apache.cassandra.service.snapshot.TakeSnapshotTask.call(TakeSnapshotTask.java:140)
	at org.apache.cassandra.service.snapshot.SnapshotManager.executeTask(SnapshotManager.java:526)
	at org.apache.cassandra.service.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:419)
	at org.apache.cassandra.service.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:435)
	at org.apache.cassandra.tools.NodeProbe.takeMultipleTableSnapshot(NodeProbe.java:933)
	at org.apache.cassandra.tools.nodetool.Snapshot.execute(Snapshot.java:97)
	at org.apache.cassandra.tools.NodeTool$NodeToolCmd.runInternal(NodeTool.java:393)
	at org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:378)
	at org.apache.cassandra.tools.NodeTool.execute(NodeTool.java:277)

Issue Links

• links to: GitHub Pull Request #3748