[CASSANDRA-20038] Investigate how to ban usages of "var" in production code.

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0.3, 5.1
• Component/s: Build
• Change Category: Code Clarity
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://issues.apache.org/jira/browse/CASSANDRA-20038

Test and Documentation Plan

CI

• Assignee: Stefan Miklosovic
• Reporter: Stefan Miklosovic

Authors

Stefan Miklosovic

Reviewers

Brandon Williams

• Created: 30/Oct/24 14:16
• Updated: 15/Nov/24 16:14
• Resolved: 31/Oct/24 15:42

Description

In this thread (1) we reached the consensus of banning usages of "var" in the production code but allowing it in tests. We should investigate how to handle this robustly, e.g. by a checkstyle rule. The investigation how to do this should be conducted.

Upon delivery, that probably means that the existing usages of "var" in the production code will need to be fixed and converted to have it all on types again because such rule would fail the compilation of the production code otherwise.

(1) https://lists.apache.org/thread/jfgj8lh1llp9zrodmfqyq22kvtlodyk6

Issue Links

• links to: GitHub Pull Request #3643