[CASSANDRA-19935] Equality check for Paxos.Electorate should not depend on collection types

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1.8, 5.0.3
• Component/s: Feature/Lightweight Transactions
• Bug Category: Degradation - Performance Bug/Regression
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: 4.1-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/9ff31e806070873449ceb6e47aaa5e25118b466f

Test and Documentation Plan

New and existing unit/dtests

• Assignee: Sam Tunnicliffe
• Reporter: Sam Tunnicliffe

Authors

Sam Tunnicliffe

Reviewers

Marcus Eriksson

• Created: 19/Sep/24 09:05
• Updated: 01/Nov/24 19:10
• Resolved: 01/Nov/24 19:10

Description

In fixing CASSANDRA-19904 on trunk, it became apparent that the comparison of local and remote electorates in Paxos::verifyElectorate does not successfully identify instances which contain the same natural and pending replicas if they are created with different implementations of Collection<InetAddressAndPort>. This causes the gossip state to be unnecessarily included in replica responses during paxos rounds, in turn thir results in unnecessary work being performed on the coordinator. This affects 4.1 and 5.0 versions, so we should backport the relevant part of the CASSANDRA-19904 patch.

Issue Links

• links to: 4.1 PR